Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSI integration part 2 #69

Merged
merged 4 commits into from
Jan 16, 2024
Merged

PSI integration part 2 #69

merged 4 commits into from
Jan 16, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jan 15, 2024

Changes to comply with PSI PR review.

@jd-lara jd-lara self-assigned this Jan 15, 2024
src/serialization.jl Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jan 15, 2024

Performance Results

Version Precompile Time
Main 1.119315578
This Branch 1.122371558
Version Execute Time
Main-Build PTDF First 5.571300316
Main-Build PTDF Second 0.115620563
Main-Build Ybus First 0.391520708
Main-Build Ybus Second 0.007602905
Main-Build LODF First 1.250937717
Main-Build LODF Second 0.180776136
This Branch-Build PTDF First 5.485686277
This Branch-Build PTDF Second 0.135431504
This Branch-Build Ybus First 0.400737895
This Branch-Build Ybus Second 0.0072514
This Branch-Build LODF First 1.208913896
This Branch-Build LODF Second 0.205572649

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (69cd65b) 78.13% compared to head (a1d636f) 78.02%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   78.13%   78.02%   -0.12%     
==========================================
  Files          15       15              
  Lines        1386     1388       +2     
==========================================
  Hits         1083     1083              
- Misses        303      305       +2     
Flag Coverage Δ
unittests 78.02% <82.60%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/BA_ABA_matrices.jl 98.07% <100.00%> (ø)
src/PowerNetworkMatrices.jl 100.00% <ø> (ø)
src/adjacency_matrix.jl 73.91% <ø> (ø)
src/common.jl 92.72% <ø> (ø)
src/incedence_matrix.jl 85.00% <ø> (ø)
src/ptdf_calculations.jl 93.06% <100.00%> (ø)
src/serialization.jl 96.25% <100.00%> (ø)
src/virtual_lodf_calculations.jl 89.88% <100.00%> (ø)
src/virtual_ptdf_calculations.jl 88.76% <100.00%> (ø)
src/lodf_calculations.jl 78.74% <93.33%> (ø)
... and 1 more

Copy link

@GabrielKS GabrielKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the typo and the suggestion to rename radial_branches and rb fields wherever they appear unless domain knowledge makes this non-confusing.

src/BA_ABA_matrices.jl Outdated Show resolved Hide resolved
src/BA_ABA_matrices.jl Outdated Show resolved Hide resolved
src/BA_ABA_matrices.jl Outdated Show resolved Hide resolved
Copy link

@GabrielKS GabrielKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jd-lara jd-lara merged commit 2c988a8 into main Jan 16, 2024
9 checks passed
@jd-lara jd-lara deleted the jd/psi_integrationv2 branch October 18, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants